-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Ported torchvision detection tutorial into sphinx gallery format #2540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2540
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 42fcc35 with merge base fca99dd ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
5e10f77
to
9f81c0a
Compare
Thanks for the PR @vfdev-5 Looks like the build is failing:
Because I'm not sure we'll be able to merge this PR before In the meantime, I guess we can go ahead and stick to updating the |
@NicolasHug I can temporarily install torchvision nightly for this tutorial and remove it in the end (inside torchvision_tutorial.py). Also, people are doing this : Line 34 in 569cf65
what would you suggest? |
e70afec
to
a02c120
Compare
I would avoid that. I'm not sure the maintainers of this repo woudl be too happy with potential breakage coming from torchvision nightly. The situation isn't really comparable to Let's just update the |
7a30f03
to
f027be9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @vfdev-5 , the tutorial and rendered docs all look good as far as I'm concerned, with some easily-addressed points:
-
some images do not render properly (like the one below, but there are others)
-
we write
torchvision.TVTensor
in some places and that doesn't really exist. Maybe we should be using~
everywhere in order for the links to look shorter, e.g.:class:`~torchvision.tv_tensors.TVTensor`
or:class:`~torchvision.tv_tensors.BoundingBoxes`
I'll let @svekars chime in regarding the changes to the CI etc.
0e42691
to
a2b39cb
Compare
092909a
to
069e507
Compare
Additional CI time to build this tutorial |
@svekars can you please review this PR regarding CI changes, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for doing this.
Description
Checklist